Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use-cases: improvements to data-registry case per Alex' review #805

Closed
wants to merge 8 commits into from

Conversation

jorgeorpinel
Copy link
Contributor

Fix #795

@shcheklein shcheklein temporarily deployed to dvc-org-pr-805 November 20, 2019 01:00 Inactive
@jorgeorpinel jorgeorpinel changed the title use-cases: improvements to data-registry case per Alex' review use-cases: improvements to data-registry case per Alex' review [WIP] Nov 20, 2019
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-pr-805 November 21, 2019 00:25 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-pr-805 November 21, 2019 00:51 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-pr-805 November 21, 2019 00:59 Inactive
@jorgeorpinel jorgeorpinel changed the title use-cases: improvements to data-registry case per Alex' review [WIP] use-cases: improvements to data-registry case per Alex' review Nov 22, 2019
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-pr-805 November 23, 2019 06:11 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-pr-805 November 24, 2019 23:46 Inactive
Copy link
Member

@shcheklein shcheklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think all the changes are pretty much cosmetic so look good to me. The only major concern is about the way we introduce the registry concept - see my comment in the ticket.

Nonetheless, I think we need to do the next iteration. Further simplify intro and put an image (WIP on my end). Introduce some section between intro and example that provides some high level abstract overview of the Git and DVC commands you would use to organize the registry, example turned out to be too complicated and specific (e.g. we focus on one specific data set that we don't even reuse and we don't mention that registry contains all the data for all example, tutorials).

@jorgeorpinel
Copy link
Contributor Author

OK. But I'm moving this it to the use-cases/data-registry branch. Unfortunately, had to create a new PR for this: #818.

@jorgeorpinel jorgeorpinel deleted the jorgeorpinel branch November 27, 2019 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use-cases: improve Data Registry case
2 participants